Skip to content

feat: add https support for condor & hummingbot-api#71

Draft
david-hummingbot wants to merge 5 commits intomainfrom
feat/add-https-support
Draft

feat: add https support for condor & hummingbot-api#71
david-hummingbot wants to merge 5 commits intomainfrom
feat/add-https-support

Conversation

@david-hummingbot
Copy link
Copy Markdown
Contributor

PR Description

This PR adds end-to-end HTTPS support between Condor and Hummingbot API, including optional custom CA trust and mTLS client certificates.

What’s included

  • Unified server URL handling in Condor (no duplicated URL builder logic)
    • Supports protocol: auto|http|https
    • auto defaults to HTTPS on port 443, HTTP otherwise
    • Validates conflicting host/protocol/port combinations
  • TLS policy per server in Condor config
    • tls_verify
    • ca_bundle_path
    • client_cert_path
    • client_key_path
  • TLS-aware client initialization
    • Applied to Condor core API client usage
    • Applied to MCP Hummingbot client usage
  • MCP server enhancements
    • configure_server supports protocol + TLS/mTLS fields
    • CLI args added for TLS options propagation
  • Tests added
    • URL resolution/validation tests
    • TLS factory validation tests
  • Docs updated
    • Condor README: HTTPS config patterns, migration notes, troubleshooting, CA/mTLS examples
    • Hummingbot API README: HTTPS setup, cert generation guidance, Condor integration

Setup automation (Hummingbot API)

  • Added interactive cert generation in setup.sh
  • Added Make targets:
    • make generate-certs
    • make run-https
    • make show-certs

Backward compatibility

Existing Condor configs continue to work unchanged. If protocol is omitted, Condor defaults to auto behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant