This repository was archived by the owner on Oct 20, 2024. It is now read-only.
Add support for a padded directive#305
Draft
lmanini wants to merge 3 commits intohuff-language:mainfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
A PR to support the request from issue #301.
Made minimal changes to add support for a
paddedkeyword, adding it to the langauge grammar and allow for a macro to have a#define paddeddirective within it.The parser's Statement generation LGTM upon a manual inspection of the (failing) added test in
huff_parser/tests/padded.rs, although I'm currently stuck, as I don't how to handle the generatedstopopcodes astSpans, given they're not present in the source file. What should we set theirSpanto?Looking for suggestions on how to solve this issue and feedback on the work done sor far!