Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the RBS for HTTP::FormData::Readable#rewind to avoid an RBS 4.0 parser error caused by using void inside a union type, aligning the signature with Ruby’s IO#rewind/StringIO#rewind behavior.
Changes:
- Replace
def rewind: () -> (Integer | void)withdef rewind: () -> IntegerinHTTP::FormData::Readable.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hakanensari
force-pushed
the
fix-rbs-void-union-syntax
branch
from
018980b to
6fda6fe
Compare
The newly-released RBS 4.0 rejects void in union types at the parser level. The (Integer | void) return type on Readable#rewind now causes a hard parse error. Change to `void`, consistent with CompositeIO#rewind and the YARD @return annotation.
hakanensari
force-pushed
the
fix-rbs-void-union-syntax
branch
from
6fda6fe to
b5301ca
Compare
Contributor
|
Thanks for this patch! It looks like RBS for was released within just a few hours of v6.0.0/v6.0.1, so I wasn't able to test with it. |
Contributor
|
Planning to ship v6.0.2 with this change shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The newly-released RBS 4.0 rejects
voidin union types at the parser level. The(Integer | void)return type onReadable#rewindnow causes a hard parse error.Change to
void, consistent with CompositeIO#rewind and the YARD @return annotation.