Conversation
NetBSD is excluded because it fails to deliver signals in CI -
reproduced by the following test failing on the last assert, `expected
signal 9, got ExitStatus(unix_wait_status(0))`.
```rust
fn stdlib_kill_vs_terminate() {
use std::os::unix::process::ExitStatusExt;
use std::process::Command;
let mut child = Command::new("sleep").arg("1000").spawn().unwrap();
let pid = child.id();
unsafe { libc::kill(pid as libc::pid_t, libc::SIGTERM) };
let status = child.wait().unwrap();
assert!(
status.signal() == Some(libc::SIGTERM),
"stdlib SIGTERM: expected signal {}, got {:?}",
libc::SIGTERM,
status
);
let mut child = Command::new("sleep").arg("1000").spawn().unwrap();
let pid = child.id();
unsafe { libc::kill(pid as libc::pid_t, libc::SIGKILL) };
let status = child.wait().unwrap();
assert!(
status.signal() == Some(libc::SIGKILL),
"stdlib SIGKILL: expected signal {}, got {:?}",
libc::SIGKILL,
status
);
}
```
We want tests to fail, not hang.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.