Add experimental_rustc_incremental flag#18
Open
walter-zeromatter wants to merge 2 commits intohermeticbuild:mainfrom
Open
Add experimental_rustc_incremental flag#18walter-zeromatter wants to merge 2 commits intohermeticbuild:mainfrom
walter-zeromatter wants to merge 2 commits intohermeticbuild:mainfrom
Conversation
Inject -Cincremental=<output_base>/.rustc_incremental_cache/... into rustc via process_wrapper when the new //rust/settings:experimental_rustc_incremental flag is set. Cache is keyed on rustc path, target, crate name, edition, action kind (full vs hollow-metadata), and a stable hash of compilation- relevant flags; argfiles are expanded at key-compute time so the values survive Bazel's param-file rewrite. Non-hermetic and local-only by design. The setting docstring documents the required --strategy=Rustc=local, --strategy=RustcMetadata=local, and --remote_upload_local_results=false recipe, plus the codegen-units runtime-perf caveat. Local benchmarking shows warm incremental rebuilds working & performing on-par with cargo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inject -Cincremental=<output_base>/.rustc_incremental_cache/... into rustc via process_wrapper when the new //rust/settings:experimental_rustc_incremental flag is set.
Non-hermetic and local-only by design. The setting docstring documents the required --strategy=Rustc=local,
--strategy=RustcMetadata=local, and --remote_upload_local_results=false recipe, plus the codegen-units runtime-perf caveat.
Local benchmarking shows warm incremental rebuilds working & performing on-par with cargo