Allow skipping over non-required progress messages#4896
Merged
crtschin merged 1 commit intohaskell:masterfrom Apr 15, 2026
Merged
Allow skipping over non-required progress messages#4896crtschin merged 1 commit intohaskell:masterfrom
crtschin merged 1 commit intohaskell:masterfrom
Conversation
b45ae8c to
b1eb311
Compare
fendor
approved these changes
Apr 15, 2026
Collaborator
fendor
left a comment
There was a problem hiding this comment.
LGTM, thank you very much, please merge when you are ready.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #4714.
I think there may be more of these
progress-related assertions, I haven't gone through it with a finetooth comb. These were the ones that were most prominent to me.What happens at each of these is that some messages don't occur at all in the message stream, the main ones being
IndexingandProcessing. I presume that we're just too fast, where ghcide finishes indexing by the time it gets a token to communicate progress.Instead of failing the test when we don't see these messages that may not occur, modify the assertion so it better matches what we expect for progress flows.
Additoinally, I made the error a bit more informative so it shows which messages it hung on. After this I repeated the tests in this file, and couldn't reproduce the failures anymore.