Add tests for active-repositories feature by erikd · Pull Request #11684 · haskell/cabal

erikd · 2026-04-01T02:03:58Z

This PR only contains tests, which were generated by Claude code, and then manually reviewed. Unfortunately I have not worked much on Cabal so my manual review may not be up-to-scratch.

This PR was submitted in preparation for taking over the work in #8997 and getting it merged. One of the things mentioned in that PR was that need for tests for the active-repositories feature.

Include the following checklist in your PR:

Patches conform to the coding conventions.
Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

erikd · 2026-04-01T04:39:52Z

I asked Claude to give me an idea of the test coverage. Its response:

The top commit (6898e42) captures the IndexUtils/ActiveRepos.hs and the index-combining
tests we added to IndexUtils.hs.

So the breakdown for what this commit actually adds vs the total feature:

Layer Coverage

Layer 1 ~80%

Layer 2 ~65%

Layer 3 ~58%

Layer 4 ~30%

Layer 5 ~0%

Where:

Layer 1 — pure logic (ActiveRepos.hs)
Layer 2 — project config parsing (pre-existing tests only, nothing new in this PR)
Layer 3 — index combining (IndexUtils.hs) (all 14 combining tests are in this PR)
Layer 4 — freeze file (filterSkippedActiveRepos unit tests in this PR)
Layer 5 — solver/planning wiring

andreabedini

I left a couple of comments but otherwise LGTM.

Not a deal breaker but any chance you can add a simple test for this edge case behaviour?

-- Note: currently if 'ActiveRepoRest' is provided more than once,
-- rest-repositories will be multiple times in the output.

mergify · 2026-04-02T08:47:59Z

Merge Queue Status

✅ Entered queue — 2026-04-02 07:42 UTC · Rule: squash-merge
✅ Checks started · on draft merge queue: embarking master (867a039), #11401 and #11684 together #11691
🚫 Left the queue — 2026-04-02 08:48 UTC · at 335c948beb59b10bed88662e161b93bec6eb4aca

This pull request spent 1 hour 5 minutes 23 seconds in the queue, including 3 seconds running CI.

Required conditions to merge

Reason

Pull request #11684 has been dequeued

merge conditions no longer match:

#approved-reviews-by >= 2 [🛡 GitHub branch protection]

#review-threads-unresolved = 0 [🛡 GitHub branch protection]

any of [🛡 GitHub branch protection]:

check-neutral = Doctest Cabal

check-skipped = Doctest Cabal

check-success = Doctest Cabal

any of [🛡 GitHub branch protection]:

check-neutral = Meta checks

check-skipped = Meta checks

check-success = Meta checks

any of [🛡 GitHub branch protection]:

check-neutral = docs/readthedocs.org:cabal

check-skipped = docs/readthedocs.org:cabal

check-success = docs/readthedocs.org:cabal

any of [🛡 GitHub branch protection]:

check-neutral = Validate post job

check-skipped = Validate post job

check-success = Validate post job

any of [🛡 GitHub branch protection]:

check-neutral = fourmolu

check-skipped = fourmolu

check-success = fourmolu

any of [🛡 GitHub branch protection]:

check-neutral = hlint

check-skipped = hlint

check-success = hlint

any of [🛡 GitHub branch protection]:

check-neutral = Bootstrap post job

check-skipped = Bootstrap post job

check-success = Bootstrap post job

any of [🛡 GitHub branch protection]:

check-neutral = whitespace

check-skipped = whitespace

check-success = whitespace

any of [🛡 GitHub branch protection]:

check-neutral = Check sdist post job

check-skipped = Check sdist post job

check-success = Check sdist post job

any of [🛡 GitHub branch protection]:

check-neutral = Changelogs

check-skipped = Changelogs

check-success = Changelogs

Hint

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

mergify · 2026-04-02T08:48:36Z

Merge Queue Status

✅ Entered queue — 2026-04-02 08:48 UTC · Rule: squash-merge
✅ Checks started · on draft merge queue: embarking master (867a039), #11401 and #11684 together #11692
🚫 Left the queue — 2026-04-02 08:59 UTC · at 335c948beb59b10bed88662e161b93bec6eb4aca

This pull request spent 11 minutes 12 seconds in the queue, including 44 seconds running CI.

Required conditions to merge

Reason

Pull request #11684 has been dequeued

merge conditions no longer match:

#approved-reviews-by >= 2 [🛡 GitHub branch protection]

#review-threads-unresolved = 0 [🛡 GitHub branch protection]

any of [🛡 GitHub branch protection]:

check-neutral = Doctest Cabal

check-skipped = Doctest Cabal

check-success = Doctest Cabal

any of [🛡 GitHub branch protection]:

check-neutral = Meta checks

check-skipped = Meta checks

check-success = Meta checks

any of [🛡 GitHub branch protection]:

check-neutral = docs/readthedocs.org:cabal

check-skipped = docs/readthedocs.org:cabal

check-success = docs/readthedocs.org:cabal

any of [🛡 GitHub branch protection]:

check-neutral = Validate post job

check-skipped = Validate post job

check-success = Validate post job

any of [🛡 GitHub branch protection]:

check-neutral = fourmolu

check-skipped = fourmolu

check-success = fourmolu

any of [🛡 GitHub branch protection]:

check-neutral = hlint

check-skipped = hlint

check-success = hlint

any of [🛡 GitHub branch protection]:

check-neutral = Bootstrap post job

check-skipped = Bootstrap post job

check-success = Bootstrap post job

any of [🛡 GitHub branch protection]:

check-neutral = whitespace

check-skipped = whitespace

check-success = whitespace

any of [🛡 GitHub branch protection]:

check-neutral = Check sdist post job

check-skipped = Check sdist post job

check-success = Check sdist post job

any of [🛡 GitHub branch protection]:

check-neutral = Changelogs

check-skipped = Changelogs

check-success = Changelogs

Hint

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

andreabedini · 2026-04-02T08:49:37Z

A changelog file is missing, here is a suggestion:

---
synopsis: Add unit tests for active-repositories feature
packages: [cabal-install]
prs: 11684
---

Add unit tests for the `active-repositories` cabal configuration field:

- `organizeByRepos`: ordering and strategy assignment with `:rest`, named repos, and error cases
- `filterSkippedActiveRepos`: filtering of skipped entries in the absence of `:rest`
- `CombineStrategy` index-combining logic (Skip/Merge/Override)
- Parse/pretty roundtrip for `ActiveRepos` (QuickCheck)

mergify · 2026-04-02T09:00:57Z

Merge Queue Status

✅ Entered queue — 2026-04-02 09:00 UTC · Rule: squash-merge
✅ Checks started · on draft merge queue: embarking master (867a039), #11401 and #11684 together #11693
🚫 Left the queue — 2026-04-02 09:11 UTC · at 335c948beb59b10bed88662e161b93bec6eb4aca

This pull request spent 10 minutes 45 seconds in the queue, including 4 seconds running CI.

Required conditions to merge

Reason

Pull request #11684 has been dequeued

merge conditions no longer match:

#approved-reviews-by >= 2 [🛡 GitHub branch protection]

#review-threads-unresolved = 0 [🛡 GitHub branch protection]

any of [🛡 GitHub branch protection]:

check-neutral = Doctest Cabal

check-skipped = Doctest Cabal

check-success = Doctest Cabal

any of [🛡 GitHub branch protection]:

check-neutral = Meta checks

check-skipped = Meta checks

check-success = Meta checks

any of [🛡 GitHub branch protection]:

check-neutral = docs/readthedocs.org:cabal

check-skipped = docs/readthedocs.org:cabal

check-success = docs/readthedocs.org:cabal

any of [🛡 GitHub branch protection]:

check-neutral = Validate post job

check-skipped = Validate post job

check-success = Validate post job

any of [🛡 GitHub branch protection]:

check-neutral = fourmolu

check-skipped = fourmolu

check-success = fourmolu

any of [🛡 GitHub branch protection]:

check-neutral = hlint

check-skipped = hlint

check-success = hlint

any of [🛡 GitHub branch protection]:

check-neutral = Bootstrap post job

check-skipped = Bootstrap post job

check-success = Bootstrap post job

any of [🛡 GitHub branch protection]:

check-neutral = whitespace

check-skipped = whitespace

check-success = whitespace

any of [🛡 GitHub branch protection]:

check-neutral = Check sdist post job

check-skipped = Check sdist post job

check-success = Check sdist post job

any of [🛡 GitHub branch protection]:

check-neutral = Changelogs

check-skipped = Changelogs

check-success = Changelogs

Hint

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

mergify · 2026-04-02T09:12:05Z

Merge Queue Status

✅ Entered queue — 2026-04-02 09:11 UTC · Rule: squash-merge
✅ Checks started · on draft merge queue: embarking master (867a039), #11401 and #11684 together #11694
🚫 Left the queue — 2026-04-02 09:23 UTC · at 335c948beb59b10bed88662e161b93bec6eb4aca

This pull request spent 11 minutes 20 seconds in the queue, including 26 seconds running CI.

Required conditions to merge

Reason

Pull request #11684 has been dequeued

merge conditions no longer match:

#approved-reviews-by >= 2 [🛡 GitHub branch protection]

#review-threads-unresolved = 0 [🛡 GitHub branch protection]

any of [🛡 GitHub branch protection]:

check-neutral = Doctest Cabal

check-skipped = Doctest Cabal

check-success = Doctest Cabal

any of [🛡 GitHub branch protection]:

check-neutral = Meta checks

check-skipped = Meta checks

check-success = Meta checks

any of [🛡 GitHub branch protection]:

check-neutral = docs/readthedocs.org:cabal

check-skipped = docs/readthedocs.org:cabal

check-success = docs/readthedocs.org:cabal

any of [🛡 GitHub branch protection]:

check-neutral = Validate post job

check-skipped = Validate post job

check-success = Validate post job

any of [🛡 GitHub branch protection]:

check-neutral = fourmolu

check-skipped = fourmolu

check-success = fourmolu

any of [🛡 GitHub branch protection]:

check-neutral = hlint

check-skipped = hlint

check-success = hlint

any of [🛡 GitHub branch protection]:

check-neutral = Bootstrap post job

check-skipped = Bootstrap post job

check-success = Bootstrap post job

Hint

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

mergify · 2026-04-10T04:48:47Z

Merge Queue Status

✅ Entered queue — 2026-04-10 04:48 UTC · Rule: default
✅ Checks started · on draft merge queue: embarking master (ade1428), #11715 and #11684 together #11728
🚫 Left the queue — 2026-04-10 04:59 UTC · at c878108b96f4a81c25cfe1b12a53b7ca2f0d7d45

This pull request spent 10 minutes 20 seconds in the queue, including 3 seconds running CI.

Required conditions to merge

Reason

Pull request #11684 has been dequeued

merge conditions no longer match:

#approved-reviews-by >= 2 [🛡 GitHub branch protection]

#review-threads-unresolved = 0 [🛡 GitHub branch protection]

any of [🛡 GitHub branch protection]:

check-neutral = Doctest Cabal

check-skipped = Doctest Cabal

check-success = Doctest Cabal

any of [🛡 GitHub branch protection]:

check-neutral = Meta checks

check-skipped = Meta checks

check-success = Meta checks

any of [🛡 GitHub branch protection]:

check-neutral = docs/readthedocs.org:cabal

check-skipped = docs/readthedocs.org:cabal

check-success = docs/readthedocs.org:cabal

any of [🛡 GitHub branch protection]:

check-neutral = Validate post job

check-skipped = Validate post job

check-success = Validate post job

any of [🛡 GitHub branch protection]:

check-neutral = fourmolu

check-skipped = fourmolu

check-success = fourmolu

any of [🛡 GitHub branch protection]:

check-neutral = hlint

check-skipped = hlint

check-success = hlint

any of [🛡 GitHub branch protection]:

check-neutral = Bootstrap post job

check-skipped = Bootstrap post job

check-success = Bootstrap post job

any of [🛡 GitHub branch protection]:

check-neutral = whitespace

check-skipped = whitespace

check-success = whitespace

any of [🛡 GitHub branch protection]:

check-neutral = Check sdist post job

check-skipped = Check sdist post job

check-success = Check sdist post job

any of [🛡 GitHub branch protection]:

check-neutral = Changelogs

check-skipped = Changelogs

check-success = Changelogs

Hint

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

andreasabel

I am afraid I do not even know what the active-repositories feature is, so I cannot judge this PR.
However, when it comes to tests: the more, the merrier!

erikd · 2026-04-11T02:10:49Z

The documentation for this feature is at: https://cabal.readthedocs.io/en/latest/cabal-project-description-file.html#cfg-field-active-repositories

mergify · 2026-04-11T19:03:13Z

Merge Queue Status

✅ Entered queue — 2026-04-11 17:09 UTC · Rule: default
✅ Checks started · on draft merge queue: embarking master (3c4c113) and #11684 together #11739
🚫 Left the queue — 2026-04-11 19:03 UTC · at 94fa99ac2c3fb5d4c4de53382b01f9f077c0c716

This pull request spent 1 hour 54 minutes 13 seconds in the queue, including 3 seconds running CI.

Waiting for:

All conditions

Reason

Pull request #11684 has been dequeued

merge conditions no longer match:

#approved-reviews-by >= 2 [🛡 GitHub branch protection]

#review-threads-unresolved = 0 [🛡 GitHub branch protection]

any of [🛡 GitHub branch protection]:

check-neutral = Doctest Cabal

check-skipped = Doctest Cabal

check-success = Doctest Cabal

any of [🛡 GitHub branch protection]:

check-neutral = Meta checks

check-skipped = Meta checks

check-success = Meta checks

any of [🛡 GitHub branch protection]:

check-neutral = docs/readthedocs.org:cabal

check-skipped = docs/readthedocs.org:cabal

check-success = docs/readthedocs.org:cabal

any of [🛡 GitHub branch protection]:

check-neutral = Validate post job

check-skipped = Validate post job

check-success = Validate post job

any of [🛡 GitHub branch protection]:

check-neutral = fourmolu

check-skipped = fourmolu

check-success = fourmolu

any of [🛡 GitHub branch protection]:

check-neutral = hlint

check-skipped = hlint

check-success = hlint

any of [🛡 GitHub branch protection]:

check-neutral = Bootstrap post job

check-skipped = Bootstrap post job

check-success = Bootstrap post job

any of [🛡 GitHub branch protection]:

check-neutral = whitespace

check-skipped = whitespace

check-success = whitespace

any of [🛡 GitHub branch protection]:

check-neutral = Check sdist post job

check-skipped = Check sdist post job

check-success = Check sdist post job

any of [🛡 GitHub branch protection]:

check-neutral = Changelogs

check-skipped = Changelogs

check-success = Changelogs

Hint

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

angerman

The applyStrategy refactor is much more readable imo, great!

Thank you @erikd for working on this!

These tests were generated by Claude code, but manually reviewed.

erikd force-pushed the master branch from 5162f1f to 6898e42 Compare April 1, 2026 02:08

erikd mentioned this pull request Apr 1, 2026

Don't override a package if all versions are deprecated #8997

Open

8 tasks

erikd force-pushed the master branch 2 times, most recently from 8a79072 to 335c948 Compare April 2, 2026 01:08

andreabedini approved these changes Apr 2, 2026

View reviewed changes

Comment thread cabal-install/tests/UnitTests/Distribution/Client/IndexUtils.hs

Comment thread cabal-install/tests/UnitTests/Distribution/Client/IndexUtils.hs Outdated

mergify bot added the queued label Apr 2, 2026

mergify bot added a commit that referenced this pull request Apr 2, 2026

Merge of #11684

910f380

mergify bot mentioned this pull request Apr 2, 2026

merge queue: embarking master (867a039), #11401 and #11684 together #11691

Closed

128 tasks

mergify bot added the dequeued label Apr 2, 2026

mergify bot removed the dequeued label Apr 2, 2026

mergify bot added a commit that referenced this pull request Apr 2, 2026

Merge of #11684

27425ed

mergify bot mentioned this pull request Apr 2, 2026

merge queue: embarking master (867a039), #11401 and #11684 together #11692

Closed

128 tasks

mergify bot added dequeued queued and removed queued labels Apr 2, 2026

mergify bot removed the dequeued label Apr 2, 2026

mergify bot added a commit that referenced this pull request Apr 2, 2026

Merge of #11684

706dea6

mergify bot mentioned this pull request Apr 2, 2026

merge queue: embarking master (867a039), #11401 and #11684 together #11693

Closed

128 tasks

mergify bot added dequeued queued and removed queued labels Apr 2, 2026

mergify bot removed the dequeued label Apr 2, 2026

mergify bot added a commit that referenced this pull request Apr 2, 2026

Merge of #11684

3d1bb8f

mergify bot mentioned this pull request Apr 2, 2026

merge queue: embarking master (867a039), #11401 and #11684 together #11694

Closed

116 tasks

mergify bot added the queued label Apr 10, 2026

erikd force-pushed the master branch from 6603bf6 to c878108 Compare April 10, 2026 04:47

mergify bot added a commit that referenced this pull request Apr 10, 2026

Merge of #11684

5020b83

mergify bot mentioned this pull request Apr 10, 2026

merge queue: embarking master (ade1428), #11715 and #11684 together #11728

Closed

128 tasks

mergify bot added dequeued and removed queued labels Apr 10, 2026

erikd force-pushed the master branch from c878108 to e2e2789 Compare April 10, 2026 05:29

mergify bot removed the dequeued label Apr 10, 2026

23Skidoo removed their request for review April 10, 2026 12:51

andreasabel reviewed Apr 10, 2026

View reviewed changes

erikd force-pushed the master branch from e2e2789 to 94fa99a Compare April 11, 2026 02:09

mergify bot added the queued label Apr 11, 2026

mergify bot added a commit that referenced this pull request Apr 11, 2026

Merge of #11684

723fab4

mergify bot mentioned this pull request Apr 11, 2026

merge queue: embarking master (3c4c113) and #11684 together #11739

Closed

128 tasks

mergify bot added dequeued and removed queued labels Apr 11, 2026

erikd force-pushed the master branch from 94fa99a to 9329e43 Compare April 12, 2026 21:20

mergify bot removed the dequeued label Apr 12, 2026

erikd force-pushed the master branch 4 times, most recently from b951c21 to 39824b2 Compare April 17, 2026 00:30

angerman added the attention: needs-review label Apr 17, 2026

angerman approved these changes Apr 17, 2026

View reviewed changes

geekosaur approved these changes Apr 17, 2026

View reviewed changes

Add tests for active-repositories feature

74ba885

These tests were generated by Claude code, but manually reviewed.

erikd force-pushed the master branch from 39824b2 to 74ba885 Compare April 18, 2026 01:05

Conversation

erikd commented Apr 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

erikd commented Apr 1, 2026

Uh oh!

andreabedini left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mergify bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Reason

Hint

Uh oh!

mergify bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Reason

Hint

Uh oh!

andreabedini commented Apr 2, 2026

Uh oh!

mergify bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Reason

Hint

Uh oh!

mergify bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Reason

Hint

Uh oh!

mergify bot commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Reason

Hint

Uh oh!

andreasabel left a comment

Choose a reason for hiding this comment

Uh oh!

erikd commented Apr 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mergify bot commented Apr 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Reason

Hint

Uh oh!

angerman left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

erikd commented Apr 1, 2026 •

edited

Loading

mergify bot commented Apr 2, 2026 •

edited

Loading

mergify bot commented Apr 2, 2026 •

edited

Loading

mergify bot commented Apr 2, 2026 •

edited

Loading

mergify bot commented Apr 2, 2026 •

edited

Loading

mergify bot commented Apr 10, 2026 •

edited

Loading

erikd commented Apr 11, 2026 •

edited

Loading

mergify bot commented Apr 11, 2026 •

edited

Loading