This repository was archived by the owner on Jan 18, 2026. It is now read-only.
feat: add custom initialisms support to gen package and avrogen#303
Merged
nrwiersma merged 4 commits intohamba:mainfrom Sep 6, 2023
hhromic:gen-initialisms
Merged
feat: add custom initialisms support to gen package and avrogen#303nrwiersma merged 4 commits intohamba:mainfrom hhromic:gen-initialisms
nrwiersma merged 4 commits intohamba:mainfrom
hhromic:gen-initialisms
Conversation
nrwiersma
suggested changes
Sep 6, 2023
Member
nrwiersma
left a comment
There was a problem hiding this comment.
One nitpick about test error assertion, otherwise looks good.
Contributor
Author
Thanks for the feedback, indeed looks cleaner after your suggestion. I merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, this simple PR adds support for custom initialisms to the
genpackage andavrogencommand.Additional custom initialisms are necessary because
strcase.ToGoPascalonly uses GoLint's list of initialisms.Currently, if an initialism in struct/field names is not part of Golint's, then
strcasewrongly downcases it.For example, consider the following schema containing the domain initialism
AID:{ "type": "record", "name": "AIDEventHTTPService", "namespace": "example", "fields" : [ {"name": "AIDNumber", "type": "long"}, {"name": "Desc", "type": "string"} ] }Currently,
avrogengenerates the following Go struct (struct/field names:AID->Aid):With this PR,
-initialisms AIDcan be given toavrogento generate the correct struct/field names:There is a related PR in the upstream
strcaserepository: ettle/strcase#13That PR allows to preserve any extra initialisms without having to define them in advance, however the maintainers seems to not be merging it any time soon. This PR allows to solve the issue in the mean time.