Open
Conversation
enable shell_exec for monitoring app
aptiko
requested changes
Apr 24, 2024
Collaborator
aptiko
left a comment
aptiko
left a comment
There was a problem hiding this comment.
I don't object to this change, provided you understand what we are doing. I'm not a PHP expert, so it's not clear to me under what circumstances shell_exec could be a security issue.
I think the commit message could be clearer, such as "Enable shell exec". It doesn't seem useful for the commit message title to say which file changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
enable shell_exec for monitoring app