Skip to content

Check for unrestricted_pointer_parameters support #4610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andyleiserson wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Check for unrestricted_pointer_parameters support #4610

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/webgpu/shader/validation/decl/override.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ Validation tests for override declarations

import { makeTestGroup } from '../../../../common/framework/test_group.js';
import { keysOf } from '../../../../common/util/data_tables.js';
import { WGSLLanguageFeature } from '../../../capability_info.js';
import { ShaderValidationTest } from '../shader_validation_test.js';

export const g = makeTestGroup(ShaderValidationTest);
Expand Down Expand Up @@ -240,7 +241,9 @@ g.test('function_scope')
t.expectCompileResult(false, code);
});

const kArrayCases = {
const kArrayCases: {
[k: string]: { code: string; valid_with_override_size: boolean; feature?: WGSLLanguageFeature };
} = {
workgroup_var: {
code: `var<workgroup> a: array<u32, size>;`,
valid_with_override_size: true,
Expand All @@ -264,6 +267,7 @@ const kArrayCases = {
workgroup_ptr_param: {
code: `fn f(a: ptr<workgroup, array<u32, size>>) {}`,
valid_with_override_size: true,
feature: 'unrestricted_pointer_parameters',
},
private_ptr_param: {
code: `fn f(a: ptr<private, array<u32, size>>) {}`,
Expand Down Expand Up @@ -298,6 +302,11 @@ g.test('array_size')
.params(u => u.combine('case', keysOf(kArrayCases)).combine('stage', ['const', 'override']))
.fn(t => {
const testcase = kArrayCases[t.params.case];

if (testcase.feature) {
t.skipIfLanguageFeatureNotSupported(testcase.feature);
}

const wgsl = `
${t.params.stage} size = 1;
${testcase.code}
Expand Down