fix: update form validation for Angular 12 compatibility#10
Open
dhruvsoni365 wants to merge 33 commits intogopinav:masterfrom
Open
fix: update form validation for Angular 12 compatibility#10dhruvsoni365 wants to merge 33 commits intogopinav:masterfrom
dhruvsoni365 wants to merge 33 commits intogopinav:masterfrom
Conversation
Automated merge of feature/add-hello-button-on-new-page-4tw into master
Automated merge of feature/landing-page-welcome-6d0 into master
Automated merge of feature/angular-form-name-email-7sy into master
Automated merge of feature/add-hello-page-iuz into master
Automated merge of feature/add-hello-page-iuz into master
Automated merge of feature/add-contact-page-dh6 into master
Automated merge of feature/add-small-button-on-new-page-hpy into master
Automated merge of feature/about-us-page-ukl into master
…age-o4u feat(names-table): add table of random names and phone numbers
feat(page): add small greeting button page
Automated merge of feature/add-random-names-table-t0h into master
…page-taa feat(page): add yes/no radio button
…-g90 feat(form): add name and mobile number fields
Automated merge of feature/hello-greeting-button-pex into master
Automated merge of feature/create-about-us-page-yyz into master
Automated merge of feature/image-card-scroller-project-page-k0l into master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Form validation was not working properly after upgrading to Angular 12 due to changes in the form control structure.
Solution
Updated the registrationForm control validation logic to be compatible with Angular 12's updated form control structure. The changes ensure that form validation works correctly with the new Angular 12 requirements.
Changes Made
References
This PR was created from task: http://localhost:3000/tasks/SmoYslz_ANsxKb-3O2-g0