chore(deps): update dependency bazelbuild/bazelisk to v1.28.1#16004
chore(deps): update dependency bazelbuild/bazelisk to v1.28.1#16004renovate-bot wants to merge 1 commit intogoogleapis:mainfrom
Conversation
|
/gcbrun |
Summary of ChangesHello @renovate-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request upgrades the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates bazelbuild/bazelisk to version v1.28.1. The changes are correct, but they highlight an area for improvement in the Dockerfiles. The bazelisk version is hardcoded in five separate files, which makes maintenance difficult. I've added a comment suggesting a refactoring to use a build argument for the version number, which would align with the repository's style guide on avoiding code duplication. This comment does not contradict any of the provided rules and is therefore kept as is.
| RUN curl -o /usr/bin/bazelisk -sSL "https://github.com/bazelbuild/bazelisk/releases/download/v1.28.1/bazelisk-linux-${ARCH}" && \ | ||
| chmod +x /usr/bin/bazelisk && \ | ||
| ln -s /usr/bin/bazelisk /usr/bin/bazel |
There was a problem hiding this comment.
The bazelisk version is hardcoded and duplicated across five different Dockerfiles: checkers.Dockerfile, fedora-latest-bazel.Dockerfile, fedora-msan.Dockerfile, ubuntu-22.04.Dockerfile, and ubuntu-24.04.Dockerfile. This makes future version updates tedious and error-prone.
To improve maintainability and adhere to the project's style guide regarding code duplication, consider defining the version using a build argument at the top of each Dockerfile.
For example:
# At the top of the Dockerfile
ARG BAZELISK_VERSION=v1.28.1
...
# In the RUN command
RUN curl -o /usr/bin/bazelisk -sSL "https://github.com/bazelbuild/bazelisk/releases/download/${BAZELISK_VERSION}/bazelisk-linux-${ARCH}" && \
chmod +x /usr/bin/bazelisk && \
ln -s /usr/bin/bazelisk /usr/bin/bazelThis would make future updates much easier. While this refactoring is larger than the current change, it would be a valuable improvement.
References
- The repository style guide prefers to factor out duplicated code if it appears 3 or more times in non-test files. The bazelisk version is duplicated across 5 Dockerfiles. (link)
2 participants
This PR contains the following updates:
v1.27.0→v1.28.1Release Notes
bazelbuild/bazelisk (bazelbuild/bazelisk)
v1.28.1Compare Source
Bazelisk v1.28.1 comes with a bug fix:
Bug Fixes & Improvements (Go)
We’d like to thank our amazing contributor @valco1994!
v1.28.0Compare Source
Bazelisk v1.28.0 comes with a new feature and several improvements:
New Features (Go)
Bug Fixes & Improvements (Go)
$PATHvalues containing a=(#720).$BAZELISK_BASE_URL: appendrcsuffix for release candidates (#722).$BAZELISK_BASE_URL: added a regression test (#734).mise(#739).completioncommand is not supported (#747).execforbazelisk runon Unix (#757).Bug Fixes & Improvements (JavaScript)
We’d like to thank our amazing contributors @cerisier, @chrisirhc, @hagl, @jmmv, @jwnimmer-tri, @jylenhof, @oxidase and @valco1994!
Configuration
📅 Schedule: Branch creation - Monday through Friday ( * * * * 1-5 ) (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.
This change is