Replace Material Icons with Google Fonts Material Symbols#488
Replace Material Icons with Google Fonts Material Symbols#488davidjiagoogle wants to merge 7 commits intomainfrom
Conversation
davidjiagoogle
force-pushed
the
david/replaceIcons
branch
from
f9c27ad to
e65e792
Compare
|
/gemini summary |
|
/gemini review |
temcguir
left a comment
temcguir
left a comment
There was a problem hiding this comment.
As we caught a few unintended visual changes in this PR (like the loss of outlined vs. filled states), it highlights a great opportunity to add screenshot testing to the project.
If we implement a visual regression testing framework, like Compose Preview Screenshot Testing, these kinds of regressions would be caught automatically by our CI.
Since we already have @Preview setups for many of our components (like ToggleSwitch and PermissionTemplate), we could generate "golden" reference images. Any future refactors, like migrating icon libraries, would instantly fail the test if the pixel output changed.
Setting that up is probably out of scope for this PR, but I highly recommend we consider adding it to our issue tracker.
Kimblebee
left a comment
Kimblebee
left a comment
There was a problem hiding this comment.
some icons were incorrect.
also i would suggest that you include "filled" or "outline" as part of the drawable naming conventions. Not all of them, but the ones that have the two vaiants. something like ic_mic_filled.xml
davidjiagoogle
force-pushed
the
david/replaceIcons
branch
from
cf14e40 to
d21166f
Compare
davidjiagoogle
force-pushed
the
david/replaceIcons
branch
from
d21166f to
1bd2b1e
Compare
There was a problem hiding this comment.
Did you mean to check this in?
There was a problem hiding this comment.
Did you mean to check this in?
There was a problem hiding this comment.
Did you mean to check this in?
3 participants
This PR replaces all usage of the standard Compose Material Icons with the equivalent Material Symbols downloaded as XML
vectors from Google Fonts. This migration reduces the dependency on the large material-icons-extended library and switches the app to the newer, variable-font-based symbol set.