Add ILP bootstrap placement pass#2667
Merged
copybara-service[bot] merged 1 commit intogoogle:mainfrom Mar 9, 2026
Merged
Conversation
dc021f7 to
895bb4c
Compare
j2kun
requested changes
Feb 21, 2026
Collaborator
j2kun
left a comment
There was a problem hiding this comment.
Looking pretty good! I have a few performance comments on the ILP, one major organizational comment on the IR update itself, and the rest are nitpicks.
lib/Analysis/ILPBootstrapPlacementAnalysis/ILPBootstrapPlacementAnalysis.cpp
Outdated
Show resolved
Hide resolved
lib/Analysis/ILPBootstrapPlacementAnalysis/ILPBootstrapPlacementAnalysis.cpp
Outdated
Show resolved
Hide resolved
lib/Analysis/ILPBootstrapPlacementAnalysis/ILPBootstrapPlacementAnalysis.cpp
Outdated
Show resolved
Hide resolved
lib/Analysis/ILPBootstrapPlacementAnalysis/ILPBootstrapPlacementAnalysis.cpp
Show resolved
Hide resolved
lib/Analysis/ILPBootstrapPlacementAnalysis/ILPBootstrapPlacementAnalysis.cpp
Outdated
Show resolved
Hide resolved
5b1bc7b to
bbc6467
Compare
3bc02ba to
916396a
Compare
Collaborator
|
Please run |
- New pass: --ilp-bootstrap-placement with option bootstrap-waterline - Debug: -debug-only=ilp-bootstrap-placement (output model constraints and solution) - Tests: bootstrap_placement_comparison.mlir, ilp_relin_modreduce_placement.mlir
Contributor
Author
Updated! |
j2kun
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an initial attempt at implementing a naive ILP-based bootstrap placement pass for more efficient bootstrap and secret-mgmt operation placement. The pass does not rely on the current secret-mgmt-insert-pass, as the pass initially solves for the level of each op, thereby determining the bootstrap and other secret-mgmt operation placement.
At a high-level, the formulation is as follows:
Note: This is still a naive ILP implementation and there are concerns yet to be addressed.
These limitations will be addressed in the future.