Use generic function to box values on heap#391
Open
willbeason wants to merge 2 commits intogoogle:masterfrom
Open
Use generic function to box values on heap#391willbeason wants to merge 2 commits intogoogle:masterfrom
willbeason wants to merge 2 commits intogoogle:masterfrom
Conversation
willbeason
force-pushed
the
generic-box-function
branch
from
3ba3fa6 to
bf1ff1e
Compare
Resolve post-1.18 todo to define a generic function that boxes a value on the heap.
willbeason
force-pushed
the
generic-box-function
branch
from
bf1ff1e to
1c813c9
Compare
Contributor
Author
|
Saw I could simplify a bit more after looking at the code in the review tool. I think I've caught all the places now that make sense to use the new generic |
dsnet
approved these changes
Mar 11, 2026
Collaborator
dsnet
left a comment
dsnet
left a comment
There was a problem hiding this comment.
Thank you, let's add another TODO to ironically wait for Go 1.27 support where we can use the expanded new semantics.
Contributor
Author
|
Anything else I should do for this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve post-1.18 todo to define a generic function that boxes a value on the heap.