Fix task name generation function name and redundancy#5192
Closed
jardondiego wants to merge 1 commit intofix-is-swarming-check-nogpufrom
Closed
Fix task name generation function name and redundancy#5192jardondiego wants to merge 1 commit intofix-is-swarming-check-nogpufrom
jardondiego wants to merge 1 commit intofix-is-swarming-check-nogpufrom
Conversation
jardondiego
commented
Mar 5, 2026
| return 't-' + str(uuid.uuid4()).lower() | ||
| def _create_task_name() -> str: | ||
| """Creates a unique task name.""" | ||
| return 't-' + str(uuid.uuid4()) |
Collaborator
Author
There was a problem hiding this comment.
.lower is redundant since uuid.uuidv4() produces a lowercase string
Collaborator
Author
|
I have identified multiple opportunities to improve overall health and quality for multiple Swarming-related modules. I think it makes the most sense to group several of those changes in a single pull request. |
Collaborator
Author
|
For now, I will close this pull request and build upon these changes to introduce more improvements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.