Swarming: Creates Feature Flag to control its usage#5190
Open
Swarming: Creates Feature Flag to control its usage#5190
Conversation
letitz
approved these changes
Mar 5, 2026
Collaborator
letitz
left a comment
There was a problem hiding this comment.
If it were me, I would put this flag in the yaml config at the root instead of in the database. Seems to me that even if we want to Turn It Off Now, we could do a rollout with a new config file / rollback to the previous version, instead of flipping a bit in the database (which leaves no audit trail, requires no review, and makes an instant global config change).
I defer to ClusterFuzz maintainers however on their method of choice for gating new functionality.
jardondiego
reviewed
Mar 5, 2026
jardondiego
reviewed
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing the swarming efforts, we add a new Feature Flag to control wether swarming tasks are allowed or not to be scheduled. so for this:
is_swarming_taskto check for the feature flagdevenvironment test proofThis feature flag has been present in the
devenv DB since last monday, but this changes were present indevunder the previous swarming state (see this PR), still the metrics seemed healthy from monday to wednesday , worth nothing that it has been set on false:So today i send them back again to
devto test this changes after the rollback and metrics continue to be healthy and no regressions seem to be introduced cause of this error. The only noticable error i saw in the logs is: