release command semaphore after timeout#911
Merged
barbibulle merged 1 commit intomainfrom Apr 16, 2026
Merged
Conversation
zxzxwu
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in issue #910, if the controller doesn't send a response in time, a timeout exception is caught, but the command semaphore isn't released, which prevents any further use of the controller.
With this change, the command semaphore will be released (and the caller will be responsible for catching the timeout). This is of course an undefined state (if the controller didn't send a response, there's no way to predict if the controller will work at all after the timeout), but it may be useful for "flaky" controllers that may still be usable after a timeout.