Conversation
- update: detect install method (brew/go/binary) and use the right updater. Homebrew users get 'brew upgrade', go install users get 'go install', manual installs get a link to releases. - status: use ○ for 'not running' instead of ● (which implies active) - install: report firewall failure honestly instead of always printing ✓ - pair/unpair: auto-restart LaunchAgent if running, instead of telling the user to do it manually - unknown commands: error with 'run clipx help' instead of silently starting the daemon
📊 Code Coverage ReportCoverage by file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Audited every command. Six fixes:
clipx update— detect install methodBefore: hardcoded
go install. Broke for Homebrew users (no Go installed) or silently installed a second binary.Now: detects how clipx was installed by checking the binary path:
Cellar/homebrewin path →brew upgrade clipx$GOPATH/bin→go install ...@latestclipx status— fix status indicatorBefore:
● clipx is not running—●implies active/healthy.Now:
○ clipx is not running.clipx install— honest firewall reportingBefore: always printed
✓ firewall exception addedeven if user cancelled sudo.Now: checks error codes, prints
⚠ firewall exception failedif it didn't work.clipx pair/unpair— auto-restartBefore:
restart clipx or run 'clipx install' to apply.Now: if LaunchAgent is running, restarts it automatically.
Unknown commands
Before:
clipx foosilently started the daemon.Now:
unknown command: foo+run 'clipx help' for usage.All extracted into a shared
restartIfRunning()helper used by pair, unpair, and update.