Skip to content

fix: gofmt -s compatibility + improved README diagram#2

Merged
karngyan merged 2 commits intomainfrom
polish-readme-gofmt
Apr 6, 2026
Merged

fix: gofmt -s compatibility + improved README diagram#2
karngyan merged 2 commits intomainfrom
polish-readme-gofmt

Conversation

@karngyan
Copy link
Copy Markdown
Member

@karngyan karngyan commented Apr 6, 2026

Fixes

gofmt -s: Go Report Card flagged clipx/node.go because the single-item const ( ... ) block can be simplified to const pollInterval = .... Older Go versions' gofmt -s catches this even though Go 1.25 doesn't.

README diagram: Replaced the cramped, misaligned ASCII art with a properly aligned version — all lines exactly 60 chars, symmetric boxes, port label, and ⌘C/⌘V hints.

  ┌──────────────────┐                  ┌──────────────────┐
  │  MacBook         │    UDP :9877     │  iMac            │
  │                  │ ──────────────►  │                  │
  │  clipx           │                  │  clipx           │
  │  192.168.0.5     │ ◄──────────────  │  192.168.0.6     │
  └──────────────────┘                  └──────────────────┘
       copy ⌘C                             paste ⌘V

karngyan added 2 commits April 6, 2026 18:04
…agram

- Replace const block with single const for pollInterval (gofmt -s compat)
- Redesign ASCII diagram: wider boxes, port label, ⌘C/⌘V hints
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 6, 2026

📊 Code Coverage Report

total:							(statements)		26.8%
Coverage by file
github.com/gomantics/clipx/clipx/clipboard.go:49:	Read			0.0%
github.com/gomantics/clipx/clipx/clipboard.go:55:	Write			0.0%
github.com/gomantics/clipx/clipx/config.go:16:		ConfigPath		100.0%
github.com/gomantics/clipx/clipx/config.go:22:		LoadConfig		77.8%
github.com/gomantics/clipx/clipx/config.go:38:		SaveConfig		71.4%
github.com/gomantics/clipx/clipx/net.go:15:		ResolveAddr		88.9%
github.com/gomantics/clipx/clipx/net.go:35:		PingPeer		0.0%
github.com/gomantics/clipx/clipx/node.go:50:		NewNode			0.0%
github.com/gomantics/clipx/clipx/node.go:55:		NewNodeWithClipboard	0.0%
github.com/gomantics/clipx/clipx/node.go:88:		Start			0.0%
github.com/gomantics/clipx/clipx/node.go:97:		Stop			0.0%
github.com/gomantics/clipx/clipx/node.go:106:		connectPeer		0.0%
github.com/gomantics/clipx/clipx/node.go:117:		sendToPeer		0.0%
github.com/gomantics/clipx/clipx/node.go:145:		listen			83.3%
github.com/gomantics/clipx/clipx/node.go:195:		handleClip		75.0%
github.com/gomantics/clipx/clipx/node.go:203:		handleChunk		81.5%
github.com/gomantics/clipx/clipx/node.go:254:		applyClipboard		85.7%
github.com/gomantics/clipx/clipx/node.go:278:		watchClipboard		0.0%
github.com/gomantics/clipx/clipx/node.go:323:		sendToAllPeers		0.0%
github.com/gomantics/clipx/clipx/node.go:374:		maintenance		0.0%
github.com/gomantics/clipx/clipx/node.go:407:		clipPreview		100.0%
github.com/gomantics/clipx/clipx/node.go:416:		isTimeout		0.0%
github.com/gomantics/clipx/clipx/node.go:423:		isConnectionError	0.0%
github.com/gomantics/clipx/clipx/protocol.go:47:	encodeMessage		100.0%
github.com/gomantics/clipx/clipx/protocol.go:58:	decodeMessage		100.0%
github.com/gomantics/clipx/clipx/protocol.go:72:	encodeClipPayload	100.0%
github.com/gomantics/clipx/clipx/protocol.go:81:	decodeClipPayload	100.0%
github.com/gomantics/clipx/clipx/protocol.go:89:	encodeChunkPayload	100.0%
github.com/gomantics/clipx/clipx/protocol.go:99:	decodeChunkPayload	100.0%
github.com/gomantics/clipx/clipx/protocol.go:111:	HashContent		100.0%
github.com/gomantics/clipx/cmd/clipx/main.go:21:	getVersion		0.0%
github.com/gomantics/clipx/cmd/clipx/main.go:31:	main			0.0%
github.com/gomantics/clipx/cmd/clipx/main.go:75:	printUsage		0.0%
github.com/gomantics/clipx/cmd/clipx/main.go:100:	cmdRun			0.0%
github.com/gomantics/clipx/cmd/clipx/main.go:133:	cmdPair			0.0%
github.com/gomantics/clipx/cmd/clipx/main.go:162:	cmdUnpair		0.0%
github.com/gomantics/clipx/cmd/clipx/main.go:198:	cmdPeers		0.0%
github.com/gomantics/clipx/cmd/clipx/main.go:213:	cmdStatus		0.0%
github.com/gomantics/clipx/cmd/clipx/main.go:240:	cmdUpdate		0.0%
github.com/gomantics/clipx/cmd/clipx/main.go:297:	launchAgentPath		0.0%
github.com/gomantics/clipx/cmd/clipx/main.go:302:	logFilePath		0.0%
github.com/gomantics/clipx/cmd/clipx/main.go:307:	cmdInstall		0.0%
github.com/gomantics/clipx/cmd/clipx/main.go:358:	cmdUninstall		0.0%
total:							(statements)		26.8%

@karngyan karngyan merged commit 578f848 into main Apr 6, 2026
2 checks passed
@karngyan karngyan deleted the polish-readme-gofmt branch April 6, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant