QueryFontMetrics nil pointer panic fix#333
Merged
justinfx merged 1 commit intogographics:masterfrom Feb 16, 2026
Merged
Conversation
[gographics/imagick@760c816](gographics@760c816) (v3.5.3, [gographics#309](gographics#309)) added a `GetLastError()` check, but the C functions can return NULL *without* setting an error - e.g. when Freetype is not compiled in. This fixes that.
Member
|
Thank you for submitting a PR for your report! I'll get this merged and can tag it tomorrow |
justinfx
pushed a commit
that referenced
this pull request
Feb 16, 2026
Member
|
Tagged v2.7.1 / v3.7.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gographics/imagick@760c816 (v3.5.3, #309) added a
GetLastError()check, but the C functions can return NULL without setting an error — e.g. when Freetype is not compiled in.Same issue in
QueryMultilineFontMetrics.Fix
Add an explicit nil check on
cdoublesafter the existing error check.