Add automatic smoothing for CSG nodes#116749
Open
Jesusemora wants to merge 8 commits intogodotengine:masterfrom
Open
Add automatic smoothing for CSG nodes#116749Jesusemora wants to merge 8 commits intogodotengine:masterfrom
Jesusemora wants to merge 8 commits intogodotengine:masterfrom
Conversation
setting the bases for autosmooth needs testing again suffix attempting to fix smoothing radians testing trying to solve crash forgot to remove line needs testing now added documentation added properties
and minor optimizations
NOTE: it was not letting me set a default value for smoothing_angle, I can't figure out why.
moved methods move variables Co-Authored-By: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Jesusemora
force-pushed
the
testing-changes
branch
from
e96285e to
1951fb5
Compare
Member
|
As a contributor to Godot CSG. I like the proposal. As you know there's a per |
Contributor
Author
I didn't know, and I don't see how that's relevant. CSG constructs an ArrayMesh, using a SurfaceTool would probably have a performance cost. It's also not very practical I think. For smoothing groups I would use 0 to disable rather than -1, because it's more intuitive. |
Clarifying and expanding the description of autosmooth and smoothing_angle properties. Optimizations to skip steps in the loops: Split loops to be able to skip vertices better and replace division with multiplication. Suggestions for future changes. Skip loop if smoothing_angle is lower than 0.1, as a more performant alternative to default smoothing. Do not compare vertices that belong to the same triangle. Remove has_smooth. Use a check at the start of the loop instead. This allows us to skip faces. Perform normalize() at the end of the loop as we don't need the normal of the vertex afterwards, as we use the normal of the face for smoothing. This way we skip normalizing flat faces. If one vertex of a triangle is connected to the current vertex, the other 2 can never physically connect, so we skip them (break;). This isn't as reliable but it could add a slight performance increase. I calculate a decrease of at least 80% of calculations in the for loops compared to the previous code.
Jesusemora
force-pushed
the
testing-changes
branch
from
30a5a18 to
e6008c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes godotengine/godot-proposals#1862
Prepares for godotengine/godot-proposals#14319 in order to implement smoothing groups, I need this and #115926 merged first, so that would be it's own PR.
Added automatic smoothing to all CSG nodes through CSGShape3D
It works on individual meshes and also on children of
CSGCombiner3D.CSGCombinerCSGBox,CSGCylinder,CSGTorus,CSGSphere,CSGPolygon3DandCSGMesh3D.autosmoothenables automatic smoothing. This overrides any smooth faces on the mesh, meaning it works on flat faced meshes like CSGBoxsmoothing_angle: when comparing two faces of a mesh, if the angle is higher than this, the vertices are smoothed, otherwise they remain sharp.Setting this to a value lower than 0.1 skips the smoothing, which could lead to a performance increase.