CI: Bump ruff hook (0.15.0 → 0.15.4)#116562
Open
Repiteo wants to merge 1 commit intogodotengine:masterfrom
Open
CI: Bump ruff hook (0.15.0 → 0.15.4)#116562Repiteo wants to merge 1 commit intogodotengine:masterfrom
Repiteo wants to merge 1 commit intogodotengine:masterfrom
Conversation
Repiteo
force-pushed
the
ci/bump-ruff
branch
2 times, most recently
from
aad61da to
1981747
Compare
Repiteo
force-pushed
the
ci/bump-ruff
branch
from
1981747 to
42a30e0
Compare
Repiteo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So originally I was gonna bump ruff as part of the PR bumping our minimum Python version, but it turns out that Ruff made a significant change starting with 0.15.2: preview builds have a new set of defaults1! Speaking as the guy who's normally all-in for cutting-edge goodies: this is way too much all at once. Granted, I have wanted to expand our ruleset for a while now, and these tentative new rules seem like a great end-goal; however, that should be achieved as a gradual roll-out from a familiar baseline. As such, this bump also freezes the "legacy" ruff ruleset alongside our current rules, which is a bit more verbose but is functionally identical to preview rulesets prior to 0.15.2
Footnotes
https://github.com/astral-sh/ruff/discussions/23203 ↩