Don't allow duplicate events in input actions editor#115822
Merged
Repiteo merged 1 commit intogodotengine:masterfrom Feb 27, 2026
Merged
Don't allow duplicate events in input actions editor#115822Repiteo merged 1 commit intogodotengine:masterfrom
Repiteo merged 1 commit intogodotengine:masterfrom
Conversation
Nintorch
force-pushed
the
fix-duplicate-inputmap-events
branch
from
34353a6 to
c3d28df
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Nintorch
force-pushed
the
fix-duplicate-inputmap-events
branch
from
c3d28df to
f67f61d
Compare
Contributor
Author
|
I added a video to show how this PR works and what the result looks like! |
Nintorch
changed the title
ActionMapEditor
AdriaandeJongh
approved these changes
Feb 27, 2026
Contributor
AdriaandeJongh
left a comment
AdriaandeJongh
left a comment
There was a problem hiding this comment.
Didn't look at the code but the usability looks good to me.
Contributor
Author
|
Thank you for your review, AdriaandeJongh! :) |
Member
|
Shouldn't the error be red? |
Contributor
|
that will help this PR, agreed! |
Contributor
Author
|
I'm not familiar with the correct way to change color of a UI text (so that it also reacts to theme color changes), so I would like some help in this regard! 😅 |
Member
|
Add (not tested) event_exists->add_theme_color_override(SceneStringName(font_color), get_theme_color(SNAME("error_color"), EditorStringName(Editor));in |
Nintorch
force-pushed
the
fix-duplicate-inputmap-events
branch
from
81e3e74 to
ce1330f
Compare
KoBeWi
approved these changes
Feb 27, 2026
Nintorch
force-pushed
the
fix-duplicate-inputmap-events
branch
from
ce1330f to
da2fb04
Compare
Contributor
Author
|
Thank you for your review, KoBeWi! :) |
Contributor
Author
Looks like it works! |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #87707
Fixes #95283
This PR checks if the
InputEventthe user is trying to add to an action already exists in that action, and if it does, the user is not allowed to add it again. Previously, it was allowed.2026-02-06.00-50-29.mp4