dist: add metrics notice to rpm and deb packages#13221
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a post-install disclosure message to Linux packages so users installing via .deb/.rpm (and going straight to the but CLI) still see a metrics collection notice.
Changes:
- Wire up a Debian
postInstallScriptin Tauri bundling config. - Add a new
deb-postinstall.shthat prints the metrics notice. - Harden RPM uninstall script and add the same notice to the RPM postinstall script.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| crates/gitbutler-tauri/tauri.conf.json | Adds postInstallScript for the Debian bundle. |
| crates/gitbutler-tauri/rpm-preremove.sh | Enables set -eu for stricter error handling during removal. |
| crates/gitbutler-tauri/rpm-postinstall.sh | Adds set -eu and prints a metrics notice after install. |
| crates/gitbutler-tauri/deb-postinstall.sh | New Debian postinstall script that prints a metrics notice. |
slarse
force-pushed
the
add-metrics-notice-to-rpm-and-deb
branch
from
b57250e to
9f850a5
Compare
This makes you aware of the metrics collection even if you don't go through the first-time GUI setup. Without this notice, jumping straight into the `but` cli leaves you completely unaware that metrics are being sent.
slarse
force-pushed
the
add-metrics-notice-to-rpm-and-deb
branch
from
9f850a5 to
9b58fff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes you aware of the metrics collection even if you don't go through the first-time GUI setup. Without this notice, jumping straight into the
butcli leaves you completely unaware that metrics are being sent.