fix(but): print normalized name after branch rename#13160
Draft
fix(but): print normalized name after branch rename#13160
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
github-actions
bot
added
rust
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes but reword <branch> print the actual (normalized) branch name after a rename, aligning CLI output with the underlying behavior where invalid names are automatically normalized.
Changes:
- Update the
rewordcommand to print the normalized branch name (and explicitly indicate when normalization occurred). - Change
but-api’supdate_branch_name_with_permto return the normalized name from the underlying branch-actions layer. - Add a regression test to assert the normalization message and final renamed branch output.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
crates/but/src/command/legacy/reword.rs |
Prints normalized branch name after rename; adds a normalization notice line when applicable. |
crates/but-api/src/legacy/stack.rs |
Returns String (normalized name) from update_branch_name_with_perm to enable correct CLI output. |
crates/but/tests/but/command/reword.rs |
Adds test coverage for branch-name normalization behavior and output. |
`but reword <branch>` always did normalize the new branch name, but the original input was what was printed afterward. This made it seem like you had created an invalid branch name, whereas in reality the name was normalized. This commit just makes the output consistent with reality.
slarse
force-pushed
the
GB-1247/reword-branch-print-normalized-name
branch
from
77ade0f to
ec3f250
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
but reword <branch>always did normalize the new branch name, but the original input was what was printed afterward. This made it seem like you had created an invalid branch name, whereas in reality the name was normalized.This PR just makes the output consistent with reality.
TODO
Tests probably need revising as I realized that trailing dashes are actually fine by Git, it's just GitButler that strips them away for some reason. I think this is wrong.