Add logger coverage lint and Claude Code PostToolUse hook#2560
Merged
hiroshinishio merged 1 commit intomainfrom Apr 20, 2026
Merged
Add logger coverage lint and Claude Code PostToolUse hook#2560hiroshinishio merged 1 commit intomainfrom
hiroshinishio merged 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/lint/check_logger_coverage.py(AST-based) enforcing CLAUDE.md logger rules: everyreturn/continue/breakin a function needs a precedinglogger.xxx(...)call, and everyif/elif/elsebranch body starts with one.scripts/git/pre_commit_hook.shso staged.pyfiles are blocked at commit time, skipping tests/scripts/schemas/venvs.PostToolUsehook (Edit|Write|MultiEdit) at.claude/hooks/check-logger-coverage.shthat runs the same check and returnsdecision:blockwith violation details so Claude fixes before continuing, not in a later commit.Social Media Post (GitAuto)
Logger coverage is now enforced automatically
Social Media Post (Wes)
Kept writing "add a logger before that return" in reviews. Moved it into a pre-commit script and a Claude Code PostToolUse hook that blocks the edit right when it happens, with the line numbers in the block reason. Same rule, one place, no more nagging.