Drop temperature from Claude calls for Opus 4.7 compatibility#2559
Merged
hiroshinishio merged 1 commit intomainfrom Apr 20, 2026
Merged
Drop temperature from Claude calls for Opus 4.7 compatibility#2559hiroshinishio merged 1 commit intomainfrom
hiroshinishio merged 1 commit intomainfrom
Conversation
Opus 4.7 deprecated the temperature parameter and returns 400 "temperature is deprecated for this model" when it's passed. This fired a flood of BadRequestError Sentry issues (AGENT-3HG through AGENT-3J1) from evaluate_condition and is_code_untestable, which call claude.beta.messages.create directly. Other Claude callers (chat_with_claude, chat_with_claude_simple, evaluate_quality_checks) were failing silently because chat_with_agent's broad fallback loop swallows the error and cycles through models, ultimately surfacing as AGENT-36M "All models exhausted." Removing temperature from all Claude call sites. Added kwargs-shape assertions to tests so a future reintroduction fails loudly. Also rewrote pre-existing partial assertions in test_is_code_untestable to exact-content equality, and added missing logger calls per CLAUDE.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.