Skip to content

Fix inconsistent test file placement by always auto-detecting location#2547

Merged
hiroshinishio merged 1 commit intomainfrom
wes
Apr 17, 2026
Merged

Fix inconsistent test file placement by always auto-detecting location#2547
hiroshinishio merged 1 commit intomainfrom
wes

Conversation

@hiroshinishio
Copy link
Copy Markdown
Collaborator

@hiroshinishio hiroshinishio commented Apr 17, 2026

Summary

  • Always auto-detect test location convention from the actual repo instead of trusting the dashboard testFileLocation default ("Co-located with source"), which was wrong for repos whose tests are actually in separate directories
  • Raised dominant-pattern threshold from 60% to 80% so only strong conventions override the co-location default
  • Rewrote coding_standards.xml file organization rules: co-location is ideal, follow 80%+ separate pattern, move/merge existing tests toward co-location, test_dir_prefixes is for finding only

Root cause

Many repos had testFileLocation: "Co-located with source" (dashboard default, never intentionally configured). This overrode auto-detection, so repos with 90%+ tests in test/ or test/specs/ got told to co-locate. The LLM received conflicting signals (prompt says co-locate, file tree shows separate dir) and picked randomly each run.

@hiroshinishio hiroshinishio self-assigned this Apr 17, 2026
@hiroshinishio hiroshinishio merged commit 139c825 into main Apr 17, 2026
1 check passed
@hiroshinishio hiroshinishio deleted the wes branch April 17, 2026 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant