Conversation
only add solution in `gsStaticComposite` if converged
add docs static optimizer change cmakelists targets
…sidual==0 in first iteration
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the TFT examples by adding benchmark executables, refining mass‐assembly output, and improving XML boundary‐condition formatting.
- Introduced two new benchmark programs for cylinder and pillow TFT cases.
- Updated mass assembly in the
static_shell_XML.cppsolver to use direct RHS output. - Expanded single‐line
<Function>tags in several XML PDE files to explicit<c>entries.
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| unittests/gsStaticSolver_test.cpp | Removed stray whitespace |
| src/gsStaticSolvers/gsStaticNewton.hpp | Initialized m_dofs from system matrix row count |
| src/gsStaticSolvers/gsStaticDR.hpp | Set m_residualIni on first residual computation |
| solvers/static_shell_XML.cpp | Switched to assembleMass(true) and updated output path |
| filedata/pde/*.xml | Reformatted zero‐value <Function> tags into <c> blocks |
| benchmarks/benchmark_cylinder_DC.cpp | Added full wrinkling benchmark implementation |
| benchmarks/benchmark_Pillow.cpp | Added pillow benchmark tweaks and new command‐line flags |
Comments suppressed due to low confidence (2)
benchmarks/benchmark_cylinder_DC.cpp:2
- The
@filecomment referencesbenchmark_TensionWrinkling.cppbut the file is namedbenchmark_cylinder_DC.cpp. Please update the comment to match the file name for clarity.
/** @file benchmark_TensionWrinkling.cpp
solvers/static_shell_XML.cpp:332
- The variable
sepis not defined in this scope, which will cause a compilation error. Consider replacing it with a literal path separator (e.g., "/" orgsFileManager::separator()) or ensuresepis defined.
gsWrite(mp_def,dirname + sep + "deformed");
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
hverhelst
commented
Jul 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add benchmarks for the paper