Skip to content

Change checkout reference from 'stable' to 'dev'#33

Merged
hverhelst merged 1 commit intomainfrom
hotfix/checkout-gismo-in-dev
Mar 3, 2026
Merged

Change checkout reference from 'stable' to 'dev'#33
hverhelst merged 1 commit intomainfrom
hotfix/checkout-gismo-in-dev

Conversation

@hverhelst
Copy link
Copy Markdown
Member

In the CI, checkout gismo in dev instead of stable branch

Copilot AI review requested due to automatic review settings March 3, 2026 14:40
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the CI workflow to build/test against the dev branch of the external gismo/gismo repository instead of stable, aligning CI with upstream development.

Changes:

  • Switch actions/checkout for gismo/gismo from ref: stable to ref: dev.
Comments suppressed due to low confidence (1)

.github/workflows/ci.yml:33

  • actions/checkout@master is a floating reference and can change unexpectedly; GitHub Actions best practice is to pin to a stable major version (e.g., actions/checkout@v4) or a full commit SHA for supply-chain safety and reproducible CI runs. Consider updating both checkout steps to a pinned version.
      - uses: actions/checkout@master
        with:
          repository: gismo/gismo
          ref: dev
          path: ./gismo

      - uses: actions/checkout@master
        with:

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/ci.yml
with:
repository: gismo/gismo
ref: stable
ref: dev
Copy link

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking out a moving branch (ref: dev) for an external dependency will make CI results non-reproducible and can introduce sudden breakages when upstream changes. If the intent is to track upstream dev, consider adding a brief comment explaining the rationale and/or pinning to a specific commit SHA (or tag) for deterministic builds, updating the pinned SHA intentionally when needed.

Suggested change
ref: dev
ref: v0.9.0

Copilot uses AI. Check for mistakes.
@hverhelst hverhelst merged commit 4a914b7 into main Mar 3, 2026
7 checks passed
@hverhelst hverhelst deleted the hotfix/checkout-gismo-in-dev branch March 3, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants