fix: Cast aggregation to Float64 in coalesce with default_value_double#7908
Draft
fix: Cast aggregation to Float64 in coalesce with default_value_double#7908
Conversation
When a conditional_aggregation has default_value_double set, the code wraps the aggregation in coalesce(expr, default_value_double). For functions like uniqIfOrNull which return UInt64, ClickHouse rejects the coalesce because UInt64 and Float64 have no common supertype (error 386). Fix: CAST the aggregation expression to Float64 before passing to coalesce when default_value_double is used. This ensures type compatibility: Before: coalesce(uniqIfOrNull(...), 0.0) -- UInt64 vs Float64 FAILS After: coalesce(CAST(uniqIfOrNull(...) AS Float64), 0.0) -- both Float64 Applied to both trace_item_table and time_series resolvers. Fixes SNUBA-APG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a conditional_aggregation has default_value_double set, the code wraps the aggregation in coalesce(expr, default_value_double). For functions like uniqIfOrNull which return UInt64, ClickHouse rejects the coalesce because UInt64 and Float64 have no common supertype (error 386).
Fix: CAST the aggregation expression to Float64 before passing to coalesce when default_value_double is used. This ensures type compatibility:
Before: coalesce(uniqIfOrNull(...), 0.0) -- UInt64 vs Float64 FAILS
After: coalesce(CAST(uniqIfOrNull(...) AS Float64), 0.0) -- both Float64
Applied to both trace_item_table and time_series resolvers.
Fixes SNUBA-APG
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.