Add timeout and retries for DSN config fetch from GitHub API#93
Draft
cursor[bot] wants to merge 1 commit intomainfrom
Draft
Add timeout and retries for DSN config fetch from GitHub API#93cursor[bot] wants to merge 1 commit intomainfrom
cursor[bot] wants to merge 1 commit intomainfrom
Conversation
Co-authored-by: Armen Zambrano G. <armenzg@users.noreply.github.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+29
to
+33
| return requests.get( | ||
| url, | ||
| headers=headers, | ||
| timeout=GITHUB_API_TIMEOUT_SECONDS, | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardened DSN config fetch in
src/sentry_config.pyagainst transient GitHub network failures that were causingConnectionError: ('Connection aborted.', ConnectionResetError(104, 'Connection reset by peer')).Changes
fetch_dsn_for_github_org.ConnectionError,Timeout).tests/test_sentry_config_file.py:ConnectionErrorValidation
python3 -m pytest tests/test_sentry_config_file.py -qpython3 -m pytest tests/test_sentry_config_file.py tests/test_web_app_handler.py -qSentry context
SENTRY-GITHUB-ACTIONS-APP-63ConnectionError: ('Connection aborted.', ConnectionResetError(104, 'Connection reset by peer'))src/sentry_config.pyinfetch_dsn_for_github_org