Skip to content

Handle GitHub App token revoke timeouts without masking primary errors#83

Draft
cursor[bot] wants to merge 1 commit intomainfrom
cursor/sentry-error-investigation-af3c
Draft

Handle GitHub App token revoke timeouts without masking primary errors#83
cursor[bot] wants to merge 1 commit intomainfrom
cursor/sentry-error-investigation-af3c

Conversation

@cursor
Copy link
Copy Markdown

@cursor cursor Bot commented Apr 19, 2026

Summary

  • guard GitHub App installation-token revocation in GithubAppToken.get_token() so cleanup network failures do not raise out of the context manager
  • log revocation failures at warning level with traceback for observability
  • add targeted unit tests for normal revocation flow and the regression case where cleanup timeout would mask the primary exception

Validation

  • python3 -m pytest tests/test_github_app.py tests/test_web_app_handler.py -q

Context

  • Investigates and mitigates Sentry issue SENTRY-GITHUB-ACTIONS-APP-6X (issue link) reporting ConnectTimeout against GitHub API during token cleanup.
Open in Web View Automation 

Co-authored-by: Armen Zambrano G. <armenzg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant