Retry GitHub App token requests on transient TLS failures#81
Draft
cursor[bot] wants to merge 1 commit intomainfrom
Draft
Retry GitHub App token requests on transient TLS failures#81cursor[bot] wants to merge 1 commit intomainfrom
cursor[bot] wants to merge 1 commit intomainfrom
Conversation
Co-authored-by: Armen Zambrano G. <armenzg@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SSLError,ConnectionError,Timeout) with linear backoffRoot Cause
Sentry issue
SENTRY-GITHUB-ACTIONS-APP-70shows failures inGithubAppToken.get_tokenwhen calling GitHub's installation token endpoint, caused by transient TLS EOF handshake errors. The previous implementation used a singlerequests.postwithout timeout or retries, so temporary upstream network flakiness immediately surfaced as 500 responses.Validation
python3 -m pytest tests/test_github_app.py tests/test_web_app_handler.py tests/test_github_sdk.py18 passed, 1 skippedRisk
Low. Change is tightly scoped to GitHub App token minting/revocation request behavior and does not alter successful request flow or authentication semantics.