Handle transient SSL failures during GitHub token revocation#80
Draft
cursor[bot] wants to merge 1 commit intomainfrom
Draft
Handle transient SSL failures during GitHub token revocation#80cursor[bot] wants to merge 1 commit intomainfrom
cursor[bot] wants to merge 1 commit intomainfrom
Conversation
Co-authored-by: Armen Zambrano G. <armenzg@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GithubAppToken.get_token()requests.RequestExceptionwhen calling GitHub's token revocation endpoint and log a warning instead of failing request handlingRoot cause
A transient network/SSL failure while revoking the temporary installation token was raised from the context manager
finallyblock. That exception replaced otherwise successful webhook processing and bubbled up as a 500.Validation
python3 -m pytest tests/test_github_app.py tests/test_web_app_handler.py10 passed, 1 skippedRisk
Low. The revocation call is cleanup-only and installation tokens already expire quickly. The change prevents false-negative webhook failures while preserving logging visibility for cleanup errors.