Skip to content

Handle GitHub token cleanup connection errors without masking root cause#78

Draft
cursor[bot] wants to merge 1 commit intomainfrom
cursor/high-impact-sentry-errors-e166
Draft

Handle GitHub token cleanup connection errors without masking root cause#78
cursor[bot] wants to merge 1 commit intomainfrom
cursor/high-impact-sentry-errors-e166

Conversation

@cursor
Copy link
Copy Markdown

@cursor cursor Bot commented Apr 18, 2026

Summary

  • harden GithubAppToken.get_token() cleanup so revocation network failures are treated as best-effort
  • prevent requests.delete() failures in the context manager finally block from masking the original webhook processing exception
  • add focused unit tests for normal revocation, cleanup connection errors, and exception-preservation behavior

Validation

  • python3 -m pytest -q

Sentry

  • Addresses error signature: ConnectionError: ('Connection aborted.', ConnectionResetError(104, 'Connection reset by peer')) in SENTRY-GITHUB-ACTIONS-APP-72
Open in Web View Automation 

Co-authored-by: Armen Zambrano G. <armenzg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant