Private method translations are not working#33
Open
pablomatiasgomez wants to merge 2 commits intogetsentry:masterfrom
Open
Private method translations are not working#33pablomatiasgomez wants to merge 2 commits intogetsentry:masterfrom
pablomatiasgomez wants to merge 2 commits intogetsentry:masterfrom
Conversation
pablomatiasgomez
commented
Mar 9, 2026
| resolved_scopes, | ||
| [ | ||
| (7..225, Some("new ApiConnector".into()), Some("new ApiConnector".into())), | ||
| (56..142, Some("ApiConnector.#t".into()), Some("ApiConnector.#makeRequest".into())), |
Author
There was a problem hiding this comment.
This test would currently fail as ApiConnector.#t and ApiConnector.#r won't be translated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found in one my apps that some private methods are not correctly being translated
I was able to reproduce a small example in this PR.
I believe the problem is that some source maps place the name mapping on the token immediately after the identifier, rather than on it.. I guess the fix would be to do the look at both the range.start and range.end on this file
js-source-scopes/src/name_resolver.rs
Line 31 in 5c08568
If so, I can do the change