Fix maven-gpg-plugin incorrectly declared as compile dependency#19
Open
micke-a wants to merge 1 commit intogetbrevo:mainfrom
Open
Fix maven-gpg-plugin incorrectly declared as compile dependency#19micke-a wants to merge 1 commit intogetbrevo:mainfrom
micke-a wants to merge 1 commit intogetbrevo:mainfrom
Conversation
…dentally included as a normal dependency. This causes all users of this library to pull in that and its transitive dependencies which is undesired, effectively forcing all users to add manual exclusions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maven-gpg-pluginwas accidentally added to the<dependencies>section with no scope (defaulting tocompile), causing it and its transitive dependencies (org.apache.maven.*,org.sonatype.sisu.*,org.apache.maven.shared.*) to leak to all consumers of this libraryexcludeblocks to work around this<dependency>entry — the plugin is already correctly declared in<build><plugins>where it belongsTest plan
mvn dependency:treeno longer includesmaven-gpg-pluginor its transitive deps in the published POMexcludeblocks🤖 Generated with Claude Code