Draft
Conversation
nohaapav
reviewed
Apr 8, 2026
| XcmTransactor(handler).transact(oracle, input); | ||
| } | ||
|
|
||
| /// @notice Fixed oracle update handler that uses the payload-embedded price |
Member
There was a problem hiding this comment.
by design .. if u use payload timestamp u effectively using oracle update timestamp than can be even day old .. StalePriceUpdate check is there is prevent processing old vaas (older than 5 minutes)
nohaapav
reviewed
Apr 8, 2026
|
|
||
| /// @notice Reset a processed VAA flag to allow replay | ||
| /// @dev EMERGENCY USE ONLY: Use when XCM execution failed on Hydration after VAA was marked processed | ||
| /// @dev VULNERABLE: After reset, anyone can call completeTransfer(vaa) to replay. |
Member
There was a problem hiding this comment.
by design .. anyone can call, front-running has no effect here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.