Add option to load KMS master key ID from the CREDSTASH_KMS_KEY_ID environment variable#292
Open
alexmbird wants to merge 1 commit intofugue:masterfrom
Open
Conversation
…vironment variable
jason-fugue
requested changes
May 7, 2021
Contributor
jason-fugue
left a comment
jason-fugue
left a comment
There was a problem hiding this comment.
Thanks for the PR! I think this is a good change, but it looks like the whitespace changes + another PR I merged earlier resulted in a conflict. Could you please resolve the conflict so that I can get this merged in?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the option to declare the KMS key using an environment variable. If the environment variable is unset, the original
alias/credstashdefault will prevail.The main use case of this is supporting the use of multiple credstashes in a single AWS account in an configure-and-forget manner.
Bonus: my text editor has automatically stripped trailing spaces from a bunch of lines :)