return context with secret material with getSecretAndContext

[kiran]

When getting a secret, it's sometimes helpful to retrieve extra context associated with it.

Note: I'm not tied to the shape of the return value.

[mike-luminal]

I like this idea, but can you rename this to getSecretAndMetadata to reduce the chance of confusion with the KMS Encryption Context?

[kiran]

@mike-luminal ah, good point. The PR is updated with the new naming.

[mike-luminal]

Hmm, it looks like this would change the default output of credstash get <secret>. Could you preserve the existing behavior and add an option such as --with-metadata to credstash get for the full output with metadata?

[kiran]

Yup, sorry!

$ credstash put -a --comment="testing comments" testsecret fake
testsecret has been stored
$ credstash get testsecret
fake
$ credstash get -m testsecret
('fake', {'version': '0000000000000000002', 'comment': 'testing comments'})
$ credstash get --include-metadata testsecret
('fake', {'version': '0000000000000000002', 'comment': 'testing comments'})

[jason-fugue]

Thanks for the PR! And sorry for the delay on this after you made the requested changes. This all looks good to me. Could you please resolve the merge conflicts and I'll get this merged in?

[kiran]

@jason-fugue thanks for the review!
I resolved the merge conflicts, and ran

$ credstash put -a --comment="testing comments" testsecret fake
testsecret has been stored
$ credstash get testsecret
fake
$ credstash get -m testsecret
('fake', {'version': '0000000000000000002', 'comment': 'testing comments'})
$ credstash get --include-metadata testsecret
('fake', {'version': '0000000000000000002', 'comment': 'testing comments'})

again, just to test, as well as rerunning the unit tests.