Open
Conversation
Support of Whirlpool and RIPEMD160 hashing methods was removed in cryptography.hazmat.primitives. pyca/cryptography@0d6aaf4
This was referenced Oct 11, 2017
Merged
Contributor
Contributor
Author
|
Thanks @wayne-luminal, I think this pr might be the proper solution. In the other solution, by locking to a particular version of the cryptography library, we will be missing bugs fixes that will be made for that library. |
Contributor
|
@jomunoz You're right. When I looked at both PRs, I see this one is failing but haven't had time to dig into what the issue is yet. I figured to get a workable credstash again I'd add temporarily add the <2.1 to cryptography. |
Contributor
|
I guess I duped this without noticing #178 :( There are some additional bits in my PR that I think might be important. |
|
hello! is there any chance this can get released? pinning down the crypto library is not a permanent solution as it breaks other ssl libraries. |
Contributor
|
@ramonamis see #178 (comment). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support of Whirlpool and RIPEMD160 hashing methods was removed in
cryptography.hazmat.primitives.
pyca/cryptography@0d6aaf4