[Repo Assist] perf: compile regex instances to module-level singletons#1162
Draft
github-actions[bot] wants to merge 2 commits intomainfrom
Draft
[Repo Assist] perf: compile regex instances to module-level singletons#1162github-actions[bot] wants to merge 2 commits intomainfrom
github-actions[bot] wants to merge 2 commits intomainfrom
Conversation
Five locations were creating a new uncompiled Regex on every call: - PageContentList.mkPageContentMenu: new Regex per page rendered - Formatting.fs (search index): Regex.Replace (static, uncompiled) per HTML page - HtmlFormatting.formatAnchor: Regex.Matches per heading processed - Menu.snakeCase: Regex.Replace (static, uncompiled) per menu item - LlmsTxt (collapseBlankLines, normaliseTitle): two Regex.Replace per page entry Each is now a module-level let binding with RegexOptions.Compiled, so the pattern is compiled once at startup and reused for the lifetime of the process. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
57 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is an automated pull request from Repo Assist.
Summary
Compile
Regexinstances to module-level singletons in five locations that were creating a new, uncompiledRegexon every call.Problem
PageContentList.mkPageContentMenuFormatting.fs(search-index strip)HtmlFormatting.formatAnchorMenu.snakeCaseLlmsTxt.collapseBlankLines/normaliseTitleEach call compiled the regex pattern from scratch, incurring unnecessary JIT overhead proportional to the number of pages/headings/menu items.
Fix
Promote each
Regexto aprivatemodule-levelletbinding withRegexOptions.Compiled. The pattern is compiled once at module load and reused for every subsequent call.Test Status
Build: 0 warnings, 0 errors
Tests: 281/281 Markdown tests pass
Generated by 🌈 Repo Assist, see workflow run.