[Repo Assist] css: introduce --surface-background and --surface-border for theming#1159
Draft
github-actions[bot] wants to merge 2 commits intomainfrom
Draft
Conversation
Five locations were creating a new uncompiled Regex on every call: - PageContentList.mkPageContentMenu: new Regex per page rendered - Formatting.fs (search index): Regex.Replace (static, uncompiled) per HTML page - HtmlFormatting.formatAnchor: Regex.Matches per heading processed - Menu.snakeCase: Regex.Replace (static, uncompiled) per menu item - LlmsTxt (collapseBlankLines, normaliseTitle): two Regex.Replace per page entry Each is now a module-level let binding with RegexOptions.Compiled, so the pattern is compiled once at startup and reused for the lifetime of the process. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
57 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This is an automated pull request from Repo Assist.
Summary
Closes #1156.
This PR introduces two new CSS custom properties to
fsdocs-default.css:--surface-background- background colour for UI surface components (copy-code button, blockquotes, sidebar menus, dialogs, tooltips, API tables)--surface-border- border colour for those same componentsBoth variables default to the header values (
--header-background/--header-border), so all existing themes are fully backwards-compatible with no changes required.Motivation
As reported in #1156,
--header-backgroundwas used for both the actual page header and every surface component background. A theme with a dark header ended up with mismatched UI elements (e.g. a black copy-code button on a light code block).Changes
--surface-background: var(--header-background)and--surface-border: var(--header-border)to:rootinfsdocs-default.css--mobile-menu-background,--aside-background,--blockquote-bacground-color,--page-menu-background-color,--page-menu-background-border-color,--nav-item-border-color,--dialog-background-color,.copy-code-button,div.fsdocs-tip, sidebar border, page-menu nav items, API table row borders, and dialog list item borders<header>background, header's border-bottom, menu-toggle button border) keep--header-*Usage after this change
Themes with a dark header but neutral content surfaces:
Test Status
Build: 0 warnings, 0 errors
Tests: 281/281 Markdown tests pass
Generated by 🌈 Repo Assist, see workflow run.