feat: update combobox to mark the popover as nonmodal#582
Merged
chrisrolfe198 merged 1 commit intomainfrom Apr 2, 2026
Merged
Conversation
chrisrolfe198
requested review from
AlanFnz,
Amin52J,
Mukesh-FN,
lizzielerwill-ctrl and
renejfc
as code owners
commit: |
Contributor
|
🎉 This PR is included in version 2.56.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add isNonModal to the ComboBox popover to avoid it causing issues with accessibility as nothing outside the popover is visible to the screen reader or to react-testing-library.
usePopover
Popover
Media
Why
How