Now attributes are setted when dragging an element on the canvas#383
Open
stijnpotters1 wants to merge 1 commit intomasterfrom
Open
Now attributes are setted when dragging an element on the canvas#383stijnpotters1 wants to merge 1 commit intomasterfrom
stijnpotters1 wants to merge 1 commit intomasterfrom
Conversation
Contributor
stijnpotters1
commented
Mar 24, 2026
stijnpotters1
commented
stijnpotters1
requested review from
Daan0709,
Matthbo,
VincentvanMedenbach,
Copilot and
philipsens
and removed request for
Copilot
|
Matthbo
reviewed
Mar 25, 2026
Member
Matthbo
left a comment
Matthbo
left a comment
There was a problem hiding this comment.
Does this set all attributes or only the required ones?
Wat about inherited attributes from the parent?
The FF Doc website has ways to recursively go through all the parents and collect their required attributes to be shown on the element details page and syntax. That should also be done here as those attributes must be set
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.