Add Contrast BadAML sandbox kernel patch on GCP#131
Draft
Conversation
Contributor
Author
|
Here are some GCP serial logs showing this - the interesting lines are the ones like this: GCP logs of lwith this patch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a possible mitigation for BadAML - a vulnerability for TDX. Full paper: https://dl.acm.org/doi/pdf/10.1145/3719027.3765123
This add the AML sandbox kernel patch from https://github.com/edgelesssys/contrast/blob/6ae47cb675597078d182976024d11e642a6f2b90/packages/by-name/kata/kernel-uvm/0001-drivers-acpi-add-BadAML-sandbox.patch which is described in the blog post https://katexochen.aro.bz/posts/badaml/
The patch is only added for GCP builds.
I think it is worth exploring other mitigations, but i wanted to test the patch as is to make sure it boots and see if anything gets denied. And it does boot but until now i have not seen anything get denied.