Fix --block-time flag being ignored due to SlotDurationMilliseconds precedence#417
Open
maoueh wants to merge 1 commit intoflashbots:mainfrom
Open
Fix --block-time flag being ignored due to SlotDurationMilliseconds precedence#417maoueh wants to merge 1 commit intoflashbots:mainfrom
maoueh wants to merge 1 commit intoflashbots:mainfrom
Conversation
…recedence Prysm v7 introduced SlotDurationMilliseconds which takes precedence over SecondsPerSlot when > 0. UnmarshalConfig seeds from MainnetConfig() which has SlotDurationMilliseconds=12000, so setting SECONDS_PER_SLOT: 1 in the template had no effect — the slot duration stayed at 12s. Explicitly sync SlotDurationMilliseconds after UnmarshalConfig so the configured block time is actually applied. A different way to fix it would be to change the CL config template that currently has `SECONDS_PER_SLOT` to use `SLOT_DURATION_MS` instead (and use Golang template to render it instead of hard-coded manual replacement)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prysm v7 introduced SlotDurationMilliseconds which takes precedence over SecondsPerSlot when > 0. UnmarshalConfig seeds from MainnetConfig() which has SlotDurationMilliseconds=12000, so setting SECONDS_PER_SLOT: 1 in the template had no effect — the slot duration stayed at 12s. Explicitly sync SlotDurationMilliseconds after UnmarshalConfig so the configured block time is actually applied.
A different way to fix it would be to change the CL config template that currently has
SECONDS_PER_SLOTto useSLOT_DURATION_MSinstead (and use Golang template to render it instead of hard-coded manual replacement)