Add post about canonical request logs in Flask#594
Open
Conversation
tushark19
reviewed
Jan 9, 2026
| g.start = time.time_ns() | ||
| ``` | ||
|
|
||
| When a new request starts we do two things. First is to call `clear_contextvars()` to remove any pre-existing values for the log (this shouldn't be an issue, but is good hygiene). Second is to set a marker for the time the request started, as we'll be adding the duration of the request to our log later on. |
There was a problem hiding this comment.
~~nit: looks cleaner
Feel free to ignore
Suggested change
| When a new request starts we do two things. First is to call `clear_contextvars()` to remove any pre-existing values for the log (this shouldn't be an issue, but is good hygiene). Second is to set a marker for the time the request started, as we'll be adding the duration of the request to our log later on. | |
| When a new request starts we do two things- | |
| - First is to call `clear_contextvars()` to remove any pre-existing values for the log (this shouldn't be an issue, but is good hygiene). | |
| - Second is to set a marker for the time the request started, as we'll be adding the duration of the request to our log later on. |
tushark19
reviewed
Jan 9, 2026
| } | ||
| ``` | ||
|
|
||
| One core element of `bind_contextvars` is that it will apply to all logs we output during the request. So if we need to log an error message during the request, as well as the final request log, those bound attributes will be included in both logs. |
There was a problem hiding this comment.
~~nit: This sounded better to me. Again feel free to ignore.
Suggested change
| One core element of `bind_contextvars` is that it will apply to all logs we output during the request. So if we need to log an error message during the request, as well as the final request log, those bound attributes will be included in both logs. | |
| One core element of `bind_contextvars` is that it will apply to all logs we output during the request. So if we log an error message during the request or the final request log, those bound attributes will be included in either of the logs. |
tushark19
approved these changes
Jan 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.